Skip to content

WhatsApp Block: Add alignment controls #17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apeatling merged 2 commits into from
Oct 8, 2020
Merged

WhatsApp Block: Add alignment controls #17308

apeatling merged 2 commits into from
Oct 8, 2020

Conversation

@apeatling
Copy link
Contributor

@apeatling apeatling commented Sep 29, 2020 •
edited by glendaviesnz
Loading

Changes proposed in this Pull Request:

  • Add WhatsApp button alignment controls to provide better support for including this button in block patterns.

Fixes #16660
2020-09-29 13 53 59

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Insert a WhatsApp Button block in a post or page
  • Change the alignment
  • Confirm this works in the editor and in the front end.

Proposed changelog entry for your changes:

  • Add ability to change the alignment of the WhatsApp button.

@apeatling apeatling added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Block] Send a message labels Sep 29, 2020
@apeatling apeatling requested a review from a team September 29, 2020 20:55
@apeatling apeatling self-assigned this Sep 29, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Sep 29, 2020 •
edited
Loading

Scheduled Jetpack release: October 6, 2020.
Scheduled code freeze: September 29, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17308

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against cd7e914

@apeatling apeatling added [Status] Needs Review This PR is ready for review. [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] Needs Review This PR is ready for review. labels Sep 29, 2020
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Sep 30, 2020

When I tested there is a float: right which overrides the the justify-content: flex-end; for right aligned which causes alignment to differ slightly in editor and front end if followed by text:

Editor:
Screen Shot 2020-09-30 at 3 43 27 PM

Frontend:
Screen Shot 2020-09-30 at 3 43 40 PM

Could be fixed by adding a float: none; along with justify-content: flex-end; but not sure what the expected behaviour is with align right, ie. is it the expectation that it will float next to following blocks?

@apeatling
Copy link
Contributor Author

apeatling commented Sep 30, 2020

I'm not sure, but I'll stop the floats and then let's see what kind of feedback we get from users and the design team.

@glendaviesnz glendaviesnz mentioned this pull request Oct 1, 2020
Closed
@apeatling apeatling added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Oct 2, 2020
@apeatling apeatling requested a review from jeherve October 5, 2020 18:54
@apeatling
Copy link
Contributor Author

apeatling commented Oct 7, 2020

This one is good for a review 👍

jeherve
jeherve approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 8, 2020
@matticbot
Copy link
Contributor

matticbot commented Oct 8, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello apeatling! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D50855-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@apeatling apeatling merged commit c336ad3 into master Oct 8, 2020
@apeatling apeatling deleted the add/whatsapp-button-alignment branch October 8, 2020 15:27
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 8, 2020
@github-actions github-actions bot added this to the 9.1 milestone Oct 8, 2020
jeherve added a commit that referenced this pull request Oct 27, 2020
@jeherve
Changelog: add #17308
4317841
@jeherve
Copy link
Member

jeherve commented Nov 10, 2020

r216550-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@apeatling apeatling

Labels

[Block] Send a message Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

Whatsapp block lacks alignment options

6 participants

@apeatling @jetpackbot @glendaviesnz @matticbot @jeherve